Skip to content

[Streams] Refine Suggestions Before Save #241439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 7, 2025
Merged

[Streams] Refine Suggestions Before Save #241439

merged 17 commits into from
Nov 7, 2025
+543 −93

Conversation

@mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Oct 31, 2025 •
edited
Loading

closes https://github.com/elastic/streams-program/issues/527

Summary

This PR allows user to edit a given partition suggestion before saving it.
Cell actions can also be used when editing an AI suggestions same as for the manually created ones.

🎥 Demo

Screen.Recording.2025-11-04.at.13.14.06.mov

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-onboarding Observability Onboarding Team Feature:Streams This is the label for the Streams Project Team:streams-program Team Label for Streams program labels Oct 31, 2025
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review November 4, 2025 11:35
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner November 4, 2025 11:35
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2025

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2025

Pinging @elastic/streams-program-team (Team:streams-program)

@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as draft November 4, 2025 11:41
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review November 4, 2025 12:16
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner November 5, 2025 10:09
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 6, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 797 799 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 916.6KB 922.7KB +6.2KB

History

thomheymann
thomheymann approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

Only issue I noticed is that the update & accept button does not seem to have a check icon. Is that intentional?

@mohamedhamed-ahmed
Copy link
Contributor Author

mohamedhamed-ahmed commented Nov 7, 2025 •
edited
Loading

Only issue I noticed is that the update & accept button does not seem to have a check icon. Is that intentional?

Yeah true, just noticed as well 😅

the old figma design does have a check. while the last image from @patpascal misses it.

I can add it with my next PR for the Partitioning Tab Tests, let me know @patpascal wdyt.

507023713-9a33115f-d71d-4da2-8c18-475fa8149f6f.png

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 5efefc1 into elastic:main Nov 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomheymann thomheymann thomheymann approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team Team:streams-program Team Label for Streams program v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohamedhamed-ahmed @elasticmachine @thomheymann @kibanamachine